Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Polymer({}) calls with ES6 class #5464

Merged
merged 3 commits into from
Jan 29, 2019
Merged

Allow Polymer({}) calls with ES6 class #5464

merged 3 commits into from
Jan 29, 2019

Conversation

dfreedm
Copy link
Member

@dfreedm dfreedm commented Jan 9, 2019

External copy of cl/228511716

@dfreedm
Allow Polymer({}) calls with ES6 class
3624a14 
External copy of cl/228511716
@dfreedm dfreedm requested a review from sorvell January 9, 2019 23:17
TimvdLippe
TimvdLippe suggested changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we have a test for this?

@dfreedm
Copy link
Member Author

dfreedm commented Jan 29, 2019

Yes, but the test will be funky because this situation is produced by a typescript decorator.

TimvdLippe
TimvdLippe approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests are really a hassle, but would be great to have them.

@dfreedm
Copy link
Member Author

dfreedm commented Jan 29, 2019

@TimvdLippe found a way to add tests :)

dfreedm added a commit that referenced this pull request Jan 29, 2019
@dfreedm
Polymer 2.x version of #5464
625a166
@dfreedm
Copy link
Member Author

dfreedm commented Jan 29, 2019

Chrome 41 failures are in master as well

TimvdLippe
TimvdLippe approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. You can merge. We should address the Chrome 41 failures in a different PR.

@dfreedm dfreedm merged commit c22b87c into master Jan 29, 2019
@dfreedm dfreedm deleted the copy-properties branch January 29, 2019 19:32
dfreedm added a commit that referenced this pull request Jan 29, 2019
@dfreedm
Merge pull request #5469 from Polymer/2.x-copy-properties
d1f36d8 
Polymer 2.x version of #5464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

@sorvell sorvell Awaiting requested review from sorvell

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfreedm @TimvdLippe @googlebot